From 617fd6cfdcb6774396f55322cc0e65a87f056ca4 Mon Sep 17 00:00:00 2001 From: Marco Pivetta Date: Wed, 14 Jan 2015 16:59:01 +0100 Subject: [PATCH] #881 DDC-2825 - moving YAML and XML mapping tests to base mapping driver tests. Excluding Static PHP mapping tests --- .../ORM/Mapping/AbstractMappingDriverTest.php | 28 +++++++++++++++++++ .../ORM/Mapping/AnnotationDriverTest.php | 26 ----------------- .../Mapping/StaticPHPMappingDriverTest.php | 22 +++++++++++++-- 3 files changed, 47 insertions(+), 29 deletions(-) diff --git a/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php b/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php index b81b3ba1e..871f0c153 100644 --- a/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php +++ b/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php @@ -9,6 +9,8 @@ use Doctrine\Tests\Models\Company\CompanyFlexContract; use Doctrine\Tests\Models\Cache\City; use Doctrine\ORM\Mapping\ClassMetadata; use Doctrine\ORM\Mapping\ClassMetadataInfo; +use Doctrine\Tests\Models\DDC2825\ExplicitSchemaAndTable; +use Doctrine\Tests\Models\DDC2825\SchemaAndTableInTableName; abstract class AbstractMappingDriverTest extends \Doctrine\Tests\OrmTestCase { @@ -932,6 +934,32 @@ abstract class AbstractMappingDriverTest extends \Doctrine\Tests\OrmTestCase $this->assertEquals(ClassMetadata::CACHE_USAGE_READ_ONLY, $class->associationMappings['attractions']['cache']['usage']); $this->assertEquals('doctrine_tests_models_cache_city__attractions', $class->associationMappings['attractions']['cache']['region']); } + + /** + * @group DDC-2825 + * @group 881 + */ + public function testSchemaDefinitionViaExplicitTableSchemaAnnotationProperty() + { + /* @var $metadata \Doctrine\ORM\Mapping\ClassMetadata */ + $metadata = $this->createClassMetadataFactory()->getMetadataFor(ExplicitSchemaAndTable::CLASSNAME); + + $this->assertSame('myschema', $metadata->getSchemaName()); + $this->assertSame('mytable', $metadata->getTableName()); + } + + /** + * @group DDC-2825 + * @group 881 + */ + public function testSchemaDefinitionViaSchemaDefinedInTableNameInTableAnnotationProperty() + { + /* @var $metadata \Doctrine\ORM\Mapping\ClassMetadata */ + $metadata = $this->createClassMetadataFactory()->getMetadataFor(SchemaAndTableInTableName::CLASSNAME); + + $this->assertSame('myschema', $metadata->getSchemaName()); + $this->assertSame('mytable', $metadata->getTableName()); + } } /** diff --git a/tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php b/tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php index 0da59e929..27dda1981 100644 --- a/tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php +++ b/tests/Doctrine/Tests/ORM/Mapping/AnnotationDriverTest.php @@ -232,32 +232,6 @@ class AnnotationDriverTest extends AbstractMappingDriverTest $this->assertArrayHasKey('example_trait_bar_id', $metadataWithoutOverride->associationMappings['bar']['joinColumnFieldNames']); $this->assertArrayHasKey('example_entity_overridden_bar_id', $metadataWithOverride->associationMappings['bar']['joinColumnFieldNames']); } - - /** - * @group DDC-2825 - * @group 881 - */ - public function testSchemaDefinitionViaExplicitTableSchemaAnnotationProperty() - { - /* @var $metadata \Doctrine\ORM\Mapping\ClassMetadata */ - $metadata = $this->createClassMetadataFactory()->getMetadataFor(ExplicitSchemaAndTable::CLASSNAME); - - $this->assertSame('myschema', $metadata->getSchemaName()); - $this->assertSame('mytable', $metadata->getTableName()); - } - - /** - * @group DDC-2825 - * @group 881 - */ - public function testSchemaDefinitionViaSchemaDefinedInTableNameInTableAnnotationProperty() - { - /* @var $metadata \Doctrine\ORM\Mapping\ClassMetadata */ - $metadata = $this->createClassMetadataFactory()->getMetadataFor(SchemaAndTableInTableName::CLASSNAME); - - $this->assertSame('myschema', $metadata->getSchemaName()); - $this->assertSame('mytable', $metadata->getTableName()); - } } /** diff --git a/tests/Doctrine/Tests/ORM/Mapping/StaticPHPMappingDriverTest.php b/tests/Doctrine/Tests/ORM/Mapping/StaticPHPMappingDriverTest.php index e82be422c..598a42ce8 100644 --- a/tests/Doctrine/Tests/ORM/Mapping/StaticPHPMappingDriverTest.php +++ b/tests/Doctrine/Tests/ORM/Mapping/StaticPHPMappingDriverTest.php @@ -2,9 +2,7 @@ namespace Doctrine\Tests\ORM\Mapping; -use Doctrine\ORM\Mapping\ClassMetadata, - Doctrine\Common\Persistence\Mapping\Driver\StaticPHPDriver, - Doctrine\ORM\Tools\Export\ClassMetadataExporter; +use Doctrine\Common\Persistence\Mapping\Driver\StaticPHPDriver; class StaticPHPMappingDriverTest extends AbstractMappingDriverTest { @@ -23,4 +21,22 @@ class StaticPHPMappingDriverTest extends AbstractMappingDriverTest { $this->createClassMetadata('Doctrine\Tests\Models\DDC889\DDC889Class'); } + + /** + * @group DDC-2825 + * @group 881 + */ + public function testSchemaDefinitionViaExplicitTableSchemaAnnotationProperty() + { + $this->markTestIncomplete(); + } + + /** + * @group DDC-2825 + * @group 881 + */ + public function testSchemaDefinitionViaSchemaDefinedInTableNameInTableAnnotationProperty() + { + $this->markTestIncomplete(); + } }