RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-02-02 21:41:45 +03:00
Code Issues Projects Releases Wiki Activity

Improve tests for DATE_ADD and DATE_SUB

Browse Source 
So that we can do proper assertions and cover all the possibilities
of the functions.
This commit is contained in:
Luís Cobucci 2017-10-30 21:29:08 +01:00
parent f277eef6ea
commit 59792654c0
No known key found for this signature in database
GPG Key ID: EC61C5F01750ED3C
1 changed files with 46 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

106
tests/Doctrine/Tests/ORM/Functional/QueryDqlFunctionTest.php
View File

@ -2,6 +2,7 @@
namespace Doctrine\Tests\ORM\Functional; namespace Doctrine\Tests\ORM\Functional;
use Doctrine\ORM\AbstractQuery;
use Doctrine\Tests\Models\Company\CompanyManager; use Doctrine\Tests\Models\Company\CompanyManager;
use Doctrine\Tests\OrmFunctionalTestCase; use Doctrine\Tests\OrmFunctionalTestCase;
@ -287,87 +288,70 @@ class QueryDqlFunctionTest extends OrmFunctionalTestCase
/** /**
* @group DDC-1014 * @group DDC-1014
*/
public function testDateAdd()
{
$arg = $this->_em->createQuery("SELECT DATE_ADD(CURRENT_TIMESTAMP(), 10, 'day') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m")
->getArrayResult();
$this->assertTrue(strtotime($arg[0]['add']) > 0);
$arg = $this->_em->createQuery("SELECT DATE_ADD(CURRENT_TIMESTAMP(), 10, 'month') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m")
->getArrayResult();
$this->assertTrue(strtotime($arg[0]['add']) > 0);
}
/**
* @group DDC-2938 * @group DDC-2938
*
* @dataProvider dateAddSubProvider
*/ */
public function testDateAddTime(): void public function testDateAdd(string $unit, int $amount, int $expectedValue, int $delta = 0) : void
{ {
$arg = $this->_em->createQuery("SELECT DATE_ADD(CURRENT_TIMESTAMP(), 10, 'second') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") $query = sprintf(
->getArrayResult(); 'SELECT CURRENT_TIMESTAMP() as now, DATE_ADD(CURRENT_TIMESTAMP(), %d, \'%s\') AS add FROM %s m',
self::assertTrue(strtotime($arg[0]['add']) > 0); $amount,
$unit,
CompanyManager::class
);
$arg = $this->_em->createQuery("SELECT DATE_ADD(CURRENT_TIMESTAMP(), 10, 'minute') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") $result = $this->_em->createQuery($query)
->getArrayResult(); ->setMaxResults(1)
self::assertTrue(strtotime($arg[0]['add']) > 0); ->getSingleResult(AbstractQuery::HYDRATE_ARRAY);
$arg = $this->_em->createQuery("SELECT DATE_ADD(CURRENT_TIMESTAMP(), 10, 'hour') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") self::assertArrayHasKey('now', $result);
->getArrayResult(); self::assertArrayHasKey('add', $result);
self::assertTrue(strtotime($arg[0]['add']) > 0);
}
public function testDateAddSecond() $diff = strtotime($result['add']) - strtotime($result['now']);
{
$dql = "SELECT CURRENT_TIMESTAMP() now, DATE_ADD(CURRENT_TIMESTAMP(), 10, 'second') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m";
$query = $this->_em->createQuery($dql)->setMaxResults(1);
$result = $query->getArrayResult();
$this->assertCount(1, $result); self::assertEquals($expectedValue, $diff, '', $delta);
$this->assertArrayHasKey('now', $result[0]);
$this->assertArrayHasKey('add', $result[0]);
$now = strtotime($result[0]['now']);
$add = strtotime($result[0]['add']);
$diff = $add - $now;
$this->assertSQLEquals(10, $diff);
} }
/** /**
* @group DDC-1014 * @group DDC-1014
* @group DDC-2938
*
* @dataProvider dateAddSubProvider
*/ */
public function testDateSub() public function testDateSub(string $unit, int $amount, int $expectedValue, int $delta = 0) : void
{ {
$arg = $this->_em->createQuery("SELECT DATE_SUB(CURRENT_TIMESTAMP(), 10, 'day') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") $query = sprintf(
->getArrayResult(); 'SELECT CURRENT_TIMESTAMP() as now, DATE_SUB(CURRENT_TIMESTAMP(), %d, \'%s\') AS sub FROM %s m',
$amount,
$unit,
CompanyManager::class
);
$this->assertTrue(strtotime($arg[0]['add']) > 0); $result = $this->_em->createQuery($query)
->setMaxResults(1)
->getSingleResult(AbstractQuery::HYDRATE_ARRAY);
$arg = $this->_em->createQuery("SELECT DATE_SUB(CURRENT_TIMESTAMP(), 10, 'month') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") self::assertArrayHasKey('now', $result);
->getArrayResult(); self::assertArrayHasKey('sub', $result);
$this->assertTrue(strtotime($arg[0]['add']) > 0); $diff = strtotime($result['now']) - strtotime($result['sub']);
self::assertEquals($expectedValue, $diff, '', $delta);
} }
/** public function dateAddSubProvider() : array
* @group DDC-2938
*/
public function testDateSubTime(): void
{ {
$arg = $this->_em->createQuery("SELECT DATE_SUB(CURRENT_TIMESTAMP(), 10, 'second') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") $secondsInDay = 86400;
->getArrayResult();
self::assertTrue(strtotime($arg[0]['add']) > 0);
$arg = $this->_em->createQuery("SELECT DATE_SUB(CURRENT_TIMESTAMP(), 10, 'minute') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") return [
->getArrayResult(); 'year' => ['year', 1, 365 * $secondsInDay, 3 * $secondsInDay],
self::assertTrue(strtotime($arg[0]['add']) > 0); 'month' => ['month', 1, 30 * $secondsInDay, 2 * $secondsInDay],
'week' => ['week', 1, 7 * $secondsInDay, $secondsInDay],
$arg = $this->_em->createQuery("SELECT DATE_SUB(CURRENT_TIMESTAMP(), 10, 'hour') AS add FROM Doctrine\Tests\Models\Company\CompanyManager m") 'hour' => ['hour', 1, 3600],
->getArrayResult(); 'minute' => ['minute', 1, 60],
self::assertTrue(strtotime($arg[0]['add']) > 0); 'second' => ['second', 10, 10],
];
} }
/** /**