RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-03-28 02:43:55 +03:00
Code Issues Projects Releases Wiki Activity

#1277 DDC-3346 DDC-3531 - refactoring test code for simplicity/readability

Browse Source
This commit is contained in:
Marco Pivetta 2015-01-23 16:19:15 +01:00
parent 16f447d1ac
commit 36bc448880
1 changed files with 16 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3346Test.php
View File

@ -15,25 +15,12 @@ class DDC3346Test extends \Doctrine\Tests\OrmFunctionalTestCase
$this->useModelSet('ddc3346'); $this->useModelSet('ddc3346');
parent::setUp(); parent::setUp();
$this->loadAuthorFixture();
} }
public function testFindOneWithEagerFetchWillNotHydrateLimitedCollection() public function testFindOneWithEagerFetchWillNotHydrateLimitedCollection()
{ {
$user = new DDC3346Author();
$user->username = "bwoogy";
$article1 = new DDC3346Article();
$article1->setAuthor($user);
$article2 = new DDC3346Article();
$article2->setAuthor($user);
$this->_em->persist($user);
$this->_em->persist($article1);
$this->_em->persist($article2);
$this->_em->flush();
$this->_em->clear();
/** @var DDC3346Author $author */ /** @var DDC3346Author $author */
$author = $this->_em->getRepository(DDC3346Author::CLASSNAME)->findOneBy( $author = $this->_em->getRepository(DDC3346Author::CLASSNAME)->findOneBy(
array('username' => "bwoogy") array('username' => "bwoogy")
@ -44,21 +31,6 @@ class DDC3346Test extends \Doctrine\Tests\OrmFunctionalTestCase
public function testFindLimitedWithEagerFetchWillNotHydrateLimitedCollection() public function testFindLimitedWithEagerFetchWillNotHydrateLimitedCollection()
{ {
$user = new DDC3346Author();
$user->username = "bwoogy";
$article1 = new DDC3346Article();
$article1->setAuthor($user);
$article2 = new DDC3346Article();
$article2->setAuthor($user);
$this->_em->persist($user);
$this->_em->persist($article1);
$this->_em->persist($article2);
$this->_em->flush();
$this->_em->clear();
/** @var DDC3346Author[] $authors */ /** @var DDC3346Author[] $authors */
$authors = $this->_em->getRepository(DDC3346Author::CLASSNAME)->findBy( $authors = $this->_em->getRepository(DDC3346Author::CLASSNAME)->findBy(
array('username' => "bwoogy"), array('username' => "bwoogy"),
@ -71,6 +43,20 @@ class DDC3346Test extends \Doctrine\Tests\OrmFunctionalTestCase
} }
public function testFindWithEagerFetchAndOffsetWillNotHydrateLimitedCollection() public function testFindWithEagerFetchAndOffsetWillNotHydrateLimitedCollection()
{
/** @var DDC3346Author[] $authors */
$authors = $this->_em->getRepository(DDC3346Author::CLASSNAME)->findBy(
array('username' => "bwoogy"),
null,
null,
1
);
$this->assertCount(1, $authors);
$this->assertCount(2, $authors[0]->articles);
}
private function loadAuthorFixture()
{ {
$user = new DDC3346Author(); $user = new DDC3346Author();
$user->username = "bwoogy"; $user->username = "bwoogy";
@ -86,16 +72,5 @@ class DDC3346Test extends \Doctrine\Tests\OrmFunctionalTestCase
$this->_em->persist($article2); $this->_em->persist($article2);
$this->_em->flush(); $this->_em->flush();
$this->_em->clear(); $this->_em->clear();
/** @var DDC3346Author[] $authors */
$authors = $this->_em->getRepository(DDC3346Author::CLASSNAME)->findBy(
array('username' => "bwoogy"),
null,
null,
1
);
$this->assertCount(1, $authors);
$this->assertCount(2, $authors[0]->articles);
} }
} }