From 33e23cdddb6366d3daa2d941db58d16f72818224 Mon Sep 17 00:00:00 2001
From: Carl Vuorinen <carl.vuorinen@gmail.com>
Date: Thu, 8 Sep 2016 11:48:34 +0300
Subject: [PATCH] PR fixes (public properties & correct letter case in
 annotations)

---
 .../Tests/Models/Issue5989/Issue5989Employee.php | 14 ++------------
 .../Tests/Models/Issue5989/Issue5989Manager.php  | 14 ++------------
 .../Tests/Models/Issue5989/Issue5989Person.php   |  7 +------
 .../ORM/Functional/Ticket/Issue5989Test.php      | 16 ++++++++--------
 4 files changed, 13 insertions(+), 38 deletions(-)

diff --git a/tests/Doctrine/Tests/Models/Issue5989/Issue5989Employee.php b/tests/Doctrine/Tests/Models/Issue5989/Issue5989Employee.php
index e3eaac7d8..9f5e248d8 100644
--- a/tests/Doctrine/Tests/Models/Issue5989/Issue5989Employee.php
+++ b/tests/Doctrine/Tests/Models/Issue5989/Issue5989Employee.php
@@ -9,19 +9,9 @@ namespace Doctrine\Tests\Models\Issue5989;
 class Issue5989Employee extends Issue5989Person
 {
     /**
-     * @column(type="simple_array", nullable=true)
+     * @Column(type="simple_array", nullable=true)
      *
      * @var array
      */
-    private $tags;
-
-    public function getTags()
-    {
-        return $this->tags;
-    }
-
-    public function setTags(array $tags)
-    {
-        $this->tags = $tags;
-    }
+    public $tags;
 }
diff --git a/tests/Doctrine/Tests/Models/Issue5989/Issue5989Manager.php b/tests/Doctrine/Tests/Models/Issue5989/Issue5989Manager.php
index 32c053984..e00067d9c 100644
--- a/tests/Doctrine/Tests/Models/Issue5989/Issue5989Manager.php
+++ b/tests/Doctrine/Tests/Models/Issue5989/Issue5989Manager.php
@@ -9,19 +9,9 @@ namespace Doctrine\Tests\Models\Issue5989;
 class Issue5989Manager extends Issue5989Person
 {
     /**
-     * @column(type="simple_array", nullable=true)
+     * @Column(type="simple_array", nullable=true)
      *
      * @var array
      */
-    private $tags;
-
-    public function getTags()
-    {
-        return $this->tags;
-    }
-
-    public function setTags(array $tags)
-    {
-        $this->tags = $tags;
-    }
+    public $tags;
 }
diff --git a/tests/Doctrine/Tests/Models/Issue5989/Issue5989Person.php b/tests/Doctrine/Tests/Models/Issue5989/Issue5989Person.php
index c9e00c4c1..d31e65def 100644
--- a/tests/Doctrine/Tests/Models/Issue5989/Issue5989Person.php
+++ b/tests/Doctrine/Tests/Models/Issue5989/Issue5989Person.php
@@ -20,10 +20,5 @@ class Issue5989Person
      * @Column(type="integer")
      * @GeneratedValue
      */
-    private $id;
-
-    public function getId()
-    {
-        return  $this->id;
-    }
+    public $id;
 }
diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/Issue5989Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/Issue5989Test.php
index 29a5a3fa2..cf601b99a 100644
--- a/tests/Doctrine/Tests/ORM/Functional/Ticket/Issue5989Test.php
+++ b/tests/Doctrine/Tests/ORM/Functional/Ticket/Issue5989Test.php
@@ -21,20 +21,20 @@ class Issue5989Test extends \Doctrine\Tests\OrmFunctionalTestCase
     {
         $manager = new Issue5989Manager();
 
-        $managerTags = array('tag1', 'tag2');
-        $manager->setTags($managerTags);
+        $managerTags = ['tag1', 'tag2'];
+        $manager->tags = $managerTags;
         $this->_em->persist($manager);
 
         $employee = new Issue5989Employee();
 
-        $employeeTags = array('tag2', 'tag3');
-        $employee->setTags($employeeTags);
+        $employeeTags =['tag2', 'tag3'];
+        $employee->tags = $employeeTags;
         $this->_em->persist($employee);
 
         $this->_em->flush();
 
-        $managerId = $manager->getId();
-        $employeeId = $employee->getId();
+        $managerId = $manager->id;
+        $employeeId = $employee->id;
 
         // clear entity manager so that $repository->find actually fetches them and uses the hydrator
         // instead of just returning the existing managed entities
@@ -45,7 +45,7 @@ class Issue5989Test extends \Doctrine\Tests\OrmFunctionalTestCase
         $manager = $repository->find($managerId);
         $employee = $repository->find($employeeId);
 
-        static::assertEquals($managerTags, $manager->getTags());
-        static::assertEquals($employeeTags, $employee->getTags());
+        static::assertEquals($managerTags, $manager->tags);
+        static::assertEquals($employeeTags, $employee->tags);
     }
 }