RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-02-02 21:41:45 +03:00
Code Issues Projects Releases Wiki Activity

[DDC-2764] Prefix criteria orderBy with rootAlias

Browse Source
This commit is contained in:
Sander Marechal 2013-10-29 11:10:34 +01:00 committed by Benjamin Eberlei
parent 45496f040d
commit 2c114756bd
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Doctrine/ORM/QueryBuilder.php
View File

@ -1098,7 +1098,7 @@ class QueryBuilder
if ($criteria->getOrderings()) { if ($criteria->getOrderings()) {
foreach ($criteria->getOrderings() as $sort => $order) { foreach ($criteria->getOrderings() as $sort => $order) {
$this->addOrderBy($sort, $order); $this->addOrderBy($this->getRootAlias() . '.' . $sort, $order);
} }
} }

5
tests/Doctrine/Tests/ORM/QueryBuilderTest.php
View File

@ -414,13 +414,16 @@ class QueryBuilderTest extends \Doctrine\Tests\OrmTestCase
public function testAddCriteriaOrder() public function testAddCriteriaOrder()
{ {
$qb = $this->_em->createQueryBuilder(); $qb = $this->_em->createQueryBuilder();
$qb->select('u')
->from('Doctrine\Tests\Models\CMS\CmsUser', 'u');
$criteria = new Criteria(); $criteria = new Criteria();
$criteria->orderBy(array('field' => Criteria::DESC)); $criteria->orderBy(array('field' => Criteria::DESC));
$qb->addCriteria($criteria); $qb->addCriteria($criteria);
$this->assertCount(1, $orderBy = $qb->getDQLPart('orderBy')); $this->assertCount(1, $orderBy = $qb->getDQLPart('orderBy'));
$this->assertEquals('field DESC', (string) $orderBy[0]); $this->assertEquals('u.field DESC', (string) $orderBy[0]);
} }
public function testAddCriteriaLimit() public function testAddCriteriaLimit()