Merge pull request #6897 from lcobucci/update-phpstan

Upgrade PHPStan to 0.9.x

.travis.yml

@@ -55,6 +55,10 @@ jobs:
       env: DB=sqlite DEPENDENCIES=low
       install: travis_retry composer update --prefer-dist --prefer-lowest
 
+    - stage: Test
+      env: DB=sqlite DEPENDENCIES=stable
+      install: travis_retry composer update --prefer-dist --prefer-stable
+
     - stage: Test
       env: DB=sqlite COVERAGE
       before_script:
@@ -68,9 +72,10 @@ jobs:
 
     - stage: Code Quality
       env: DB=none STATIC_ANALYSIS
+      install: travis_retry composer update --prefer-dist --prefer-stable
       before_script:
         - echo "extension=redis.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini
-        - travis_retry composer require --dev --prefer-dist --prefer-stable phpstan/phpstan:^0.8 symfony/console:^3.0
+        - travis_retry composer require --dev --prefer-dist --prefer-stable phpstan/phpstan:^0.9
       script: vendor/bin/phpstan analyse -l 1 -c phpstan.neon lib
 
     - stage: Code Quality

lib/Doctrine/ORM/Internal/CommitOrderCalculator.php

@@ -52,7 +52,7 @@ class CommitOrderCalculator
      * - <b>dependencyList</b> (array<string>)
      * Map of node dependencies defined as hashes.
      *
-     * @var array<stdClass>
+     * @var array<\stdClass>
      */
     private $nodeList = [];
 

lib/Doctrine/ORM/Query/Parser.php

@@ -834,6 +834,8 @@ class Parser
      */
     public function QueryLanguage()
     {
+        $statement = null;
+
         $this->lexer->moveNext();
 
         switch ($this->lexer->lookahead['type']) {

lib/Doctrine/ORM/Tools/Export/Driver/YamlExporter.php

@@ -158,7 +158,7 @@ class YamlExporter extends AbstractExporter
                 $associationMappingArray['fetch'] = $this->_getFetchModeString($associationMapping['fetch']);
             }
 
-            if (isset($mapping['id']) && $mapping['id'] === true) {
+            if (isset($associationMapping['id']) && $associationMapping['id'] === true) {
                 $array['id'][$name]['associationKey'] = true;
             }