From 044b202379dd9cfc769b83695a3e8a5f82572a19 Mon Sep 17 00:00:00 2001 From: Marco Pivetta Date: Fri, 11 Dec 2015 20:50:18 +0100 Subject: [PATCH] Simplifying `getColumnNames` logic (can be an `array_map` call) --- lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php index 62d51ce16..90db1f8a6 100644 --- a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php +++ b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php @@ -1873,17 +1873,11 @@ class ClassMetadataInfo implements ClassMetadata */ public function getColumnNames(array $fieldNames = null) { - if ($fieldNames === null) { + if (null === $fieldNames) { return array_keys($this->fieldNames); } - $columnNames = array(); - - foreach ($fieldNames as $fieldName) { - $columnNames[] = $this->getColumnName($fieldName); - } - - return $columnNames; + return array_values(array_map([$this, 'getColumnName'], $fieldNames)); } /**