RetailCRM-Mirror/bitrix-module
1
0
Fork 0
mirror of synced 2024-11-25 14:56:09 +03:00
Code Issues Projects Releases Wiki Activity

Merge pull request #82 from Frosin/master

Browse Source 
Добавлены обработки ошибок при сохранении платежей.
This commit is contained in:
Alex Lushpai 2019-10-03 15:52:05 +03:00 committed by GitHub
commit 58b2348ce3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
intaro.retailcrm/classes/general/history/RetailCrmHistory_v5.php
View File

@ -774,7 +774,10 @@ class RetailCrmHistory
if (array_key_exists($orderPayment->getField('XML_ID'), $newHistoryPayments)) { if (array_key_exists($orderPayment->getField('XML_ID'), $newHistoryPayments)) {
$paymentId = $orderPayment->getId(); $paymentId = $orderPayment->getId();
$paymentExternalId = RCrmActions::generatePaymentExternalId($paymentId); $paymentExternalId = RCrmActions::generatePaymentExternalId($paymentId);
if (is_null($paymentId)) {
RCrmActions::eventLog('RetailCrmHistory::orderHistory', 'paymentsUpdate', 'Save payment error, order=' . $order['number']);
continue;
}
if ($paymentExternalId) { if ($paymentExternalId) {
$newHistoryPayments[$orderPayment->getField('XML_ID')]['externalId'] = $paymentExternalId; $newHistoryPayments[$orderPayment->getField('XML_ID')]['externalId'] = $paymentExternalId;
RCrmActions::apiMethod($api, 'paymentEditById', __METHOD__, $newHistoryPayments[$orderPayment->getField('XML_ID')]); RCrmActions::apiMethod($api, 'paymentEditById', __METHOD__, $newHistoryPayments[$orderPayment->getField('XML_ID')]);
@ -1166,7 +1169,7 @@ class RetailCrmHistory
unset($paymentsList[$nowPaymentId]); unset($paymentsList[$nowPaymentId]);
} }
} else { } elseif (array_key_exists($paymentCrm['type'], $optionsPayTypes)) {
$newHistoryPayments[$paymentCrm['id']] = $paymentCrm; $newHistoryPayments[$paymentCrm['id']] = $paymentCrm;
$newPayment = $paymentColl->createItem(); $newPayment = $paymentColl->createItem();
$newPayment->setField('SUM', $paymentCrm['amount']); $newPayment->setField('SUM', $paymentCrm['amount']);
@ -1183,6 +1186,8 @@ class RetailCrmHistory
$newPaymentId = $newPayment->getId(); $newPaymentId = $newPayment->getId();
unset($paymentsList[$newPaymentId]); unset($paymentsList[$newPaymentId]);
} else {
RCrmActions::eventLog('RetailCrmHistory::orderHistory', 'paymentsUpdate', 'Save payment error, incorrect type: ' . $paymentCrm['type']);
} }
if ($optionsPayment[$paymentCrm['status']] == 'Y') { if ($optionsPayment[$paymentCrm['status']] == 'Y') {