Mark Baker
6c8884b2eb
Hopefully final tweak for XXE to prevent displaying errors if SimpleXML isn't available
2014-02-21 10:28:17 +00:00
Mark Baker
2f4fd4cdcb
Merge branch 'develop' of https://github.com/PHPOffice/PHPExcel into develop
2014-02-21 10:22:28 +00:00
Mark Baker
16c1a19d34
Update security section in Reader documentation
2014-02-21 10:21:04 +00:00
Maarten Balliauw
81c1c55149
Merge pull request #323 from maartenba/develop
...
When libxmlloader options are the default values, disable the entity loader as well. CVE-2014-2054 by MITRE
2014-02-21 11:07:35 +01:00
Maarten Balliauw
fdc4532bc7
When libxmlloader options are teh default values, disable the entity loader as well. CVE-2014-2054 by MITRE
2014-02-21 11:06:44 +01:00
Mark Baker
1abf061df3
AS we're using simpleXML for xml reading still, we need to use libxml_disable_entity_loader(true); for XXE security patch
2014-02-21 10:01:44 +00:00
Mark Baker
98205e5ec7
Warning in security docs
2014-02-21 09:56:57 +00:00
Mark Baker
c243bcb8ad
Updated documentation for XXE injection in readers
2014-02-21 09:51:59 +00:00
Maarten Balliauw
e04bf7ed09
Merge pull request #322 from maartenba/develop
...
Disabled libxml external entity loading by default.
2014-02-21 09:26:01 +01:00
Maarten Balliauw
1dad681142
Disabled libxml external entity loading by default.
...
If you want to allow loading external entity references in XML, call PHPExcel_Settings::setLibXmlLoaderOptions(0).
2014-02-21 09:23:55 +01:00
Mark Baker
220da7485e
Bugfix: Work item CP20703 - Calculation engine incorrectly evaluates empty cells as #VALUE
2014-02-09 16:08:17 +00:00
Mark Baker
353c46886c
Extend headers to handle IE 9 problems and IE/SSL caching problems
2014-02-09 15:27:36 +00:00
Adrien Crivelli
a0da3e32ec
Double quote support for SUMIF() condition
...
SUMIF() condition can have double quote, such as '=SUMIF(A2:A4,">""",B2:B4)'.
This formula purpose is to compare the character double quote (").
In our previous patch (commit f1a1f525
) we wrongly assumed that
PHPExcel_Calculation_MathTrig::SUMIF() expected the condition to escaped ('>""'),
but this is actually not the case in real use of PHPExcel, so the unit tests were
modified accordingly to use non-escaped condition ('>"').
2014-01-17 21:01:57 +09:00
Mark Baker
496b76e70a
Bugfix: Work Item CP20604 - Adding Sheet to Workbook Bug
2014-01-08 10:15:07 +00:00
Navarr Barnier
dde17c4e1d
Add ext-xmlwriter as a Composer requirement
...
XMLWriter is surprisingly a different extension from xml; and so is not installed on some systems (such as Gentoo). This commit enforces it to be installed, since it's necessary for the functionality of PHPExcel.
2014-01-03 16:59:32 -05:00
Mark Baker
992aee683a
Update to copyright year in file headers
2013-12-31 18:36:33 +00:00
Mark Baker
93b3b8eed2
Bugfix: Work Item GH-290 - AdvancedValueBinder "Division by zero"-error
2013-12-31 01:13:06 +00:00
Mark Baker
70892b93c8
Bugfix: (EliuFlorez) Work item GH-279 - Fatal error: Call to a member function cellExists() line: 3327 in calculation.php if referenced worksheet doesn't exist
2013-12-31 00:06:56 +00:00
Mark Baker
4a18c9cf58
Merge pull request #279 from EliuFlorez/patch-1
...
Update Calculation.php
2013-12-30 16:04:26 -08:00
Mark Baker
dc97d2f46b
Improve fluent interface in charting methods
2013-12-30 23:44:42 +00:00
Mark Baker
19fc61114d
Bugfix: (Roy Shahbazian) Work Item GH-299 - Fixed typo in Chart/Layout set/getYMode()
2013-12-30 22:27:40 +00:00
Mark Baker
8cd6f56fdd
Bugfix: (Jazzo) Work Item GH-248 - Excel2007 does not correctly mark rows as hidden
2013-12-30 22:19:05 +00:00
Mark Baker
2bcaa01ecc
Bugfix: Work Item GH-193 - Fix to empty worksheet garbage collection when using cell caching
2013-12-29 23:48:42 +00:00
Mark Baker
30070f35c2
Bugfix: Work Item GH-257 - Passing an array of cells to _generateRow() in the HTML/PDF Writer causes caching problems with last cell in the range
2013-12-28 13:40:24 +00:00
Mark Baker
56eae54a4b
Minor fix to chart layout
2013-12-23 08:13:12 +00:00
Mark Baker
fcb794e2e2
Bugfix: Work Item GH-275 - Insert New Row/Column Before is not correctly updating formula references
2013-12-09 23:45:45 +00:00
Mark Baker
e79181cb4d
Bugfix: Work Item GH-275 - Insert New Row/Column Before is not correctly updating formula references
2013-12-09 22:33:45 +00:00
Eliu Florez
b9907446a3
Update Calculation.php
...
PHPExcel Fatal error: Call to a member function cellExists() line: 3327
2013-12-04 22:46:55 -04:30
Mark Baker
7a90c5b888
Mods to handle encrypted files on both 32-bit and 64-bit versions of PHP - currently only tested on 32-bit Windows
2013-12-03 13:51:40 +00:00
Mark Baker
ee03569d72
General: (infojunkie) Work Item GH-276 - Convert properties to string in OOCalc reader
2013-12-01 11:37:10 +00:00
Mark Baker
9f93cab6c5
Merge pull request #276 from infojunkie/OOCalcReaderXML
...
Convert properties to string in OOCalc reader
2013-12-01 03:34:54 -08:00
Mark Baker
c7a6431e09
Feature: (trvrnrth) Work Item GH-261 - Add support for reading protected (RC4 encrypted) .xls files (tweaked for PHP 5.2 compatibility)
2013-11-28 23:43:57 +00:00
infojunkie
b671d8376f
Convert properties to string in OOCalc reader
2013-11-25 16:18:46 -08:00
Mark Baker
4570c52d2a
Bugfix: (PowerKiKi) Work Item GH-270/GH-31 - Binary comparison of strings are case insensitive
2013-11-23 21:38:09 +00:00
Mark Baker
56c9d079d1
Merge pull request #270 from PowerKiKi/issue_31
...
Binary comparaison of strings are case insensitive
2013-11-23 13:36:16 -08:00
Mark Baker
f2f097733b
Bugfix: (PowerKiKi) Work Item GH-273 - ISTEXT() return wrong result if referencing an empty but formatted cell
2013-11-23 21:22:06 +00:00
Mark Baker
aa5a9d4168
Merge pull request #273 from PowerKiKi/issue_is_text
...
ISTEXT() return wrong result if referencing an empty but formatted cell
2013-11-23 13:00:50 -08:00
Adrien Crivelli
5d6687b6ce
ISTEXT() return wrong result if referencing an empty but formatted cell
...
ISTEXT should always return FALSE for empty cells, however PHPExcel returns
TRUE if the cell is formatted. This can be reproduced in Excel by choosing
formatting category "Text" for cell A1, and then in cell B1 input the
formula '=ISTEXT(A1)'. B1 will display FALSE, but PHPExcel will return TRUE.
This patch fix the NULL value being incorrectly cast to an empty string, and
thus eliminating ISTEXT() issue (and probably several others).
2013-11-22 19:33:56 +09:00
Adrien Crivelli
f2e24ecdd4
Comparison operators on strings are usually case insensitive
...
Excel, Gnumeric and Google Spreadsheet are case insensitive, so the
default behavior of PHPExcel is modified accordingly.
However OpenOffice is case sensitive and is also supported via the
compatibility mode of PHPExcel.
Fixes #31
2013-11-21 16:04:59 +09:00
Mark Baker
f5bd6dc0f2
Bugfix: (IndrekHaav) Work Item CP16208 - Fixed undefined variable error due to $styleArray being used before it's initialised
2013-11-18 14:28:22 +00:00
Mark Baker
9c6287a323
Bugfix: (IndrekHaav) Work Item GH-212 - Fix for formulae that reference a sheet whose name begins with a digit:
...
these were erroneously identified as numeric values, causing the parser to throw an undefined variable error.
2013-11-18 14:20:37 +00:00
Mark Baker
30459d260d
General: (RomanSyroeshko) GB-265 - PHPExcel_Shared_String.IsUTF8 returns FALSE for Cyrillic UTF-8 input
2013-11-18 08:00:49 +00:00
Mark Baker
7f0a8044a4
Markdown charset, second attempt
2013-11-17 21:45:30 +00:00
Mark Baker
dc416f83a5
Fix UTF-8 in markdown
2013-11-17 21:36:43 +00:00
Mark Baker
aa660150ae
Documentation (jamescostian) GH-234 - Fixed some malformed Markdown
2013-11-17 19:52:35 +00:00
Mark Baker
f3755a0965
Documentation fix: (PowerKiKi) GH-224 - Minor fix in DocBlock
2013-11-17 19:43:47 +00:00
Mark Baker
4eefabf7a0
Modify OOCalc reader to work with PCLZip rather than ZipArchive if configured to do so
2013-11-17 17:45:21 +00:00
Mark Baker
0d8a5d1f0b
General: (adamriyadi) Work Item GH-247 - Modify PHPExcel_Reader_Excel2007 to use zipClass from PHPExcel_Settings::getZipClass()
...
This allows the use of PCLZip when reading for people that don't have access to ZipArchive
2013-11-17 17:33:56 +00:00
Mark Baker
7fb98dbcd5
Fix to new PCLZip wrapper locateName() method
2013-11-17 14:15:22 +00:00
Mark Baker
51a1661c79
Feature: (adamriyadi) GH-247 - Add locateName() and getFromName() to PHPExcel_Shared_ZipArchive
2013-11-17 13:09:11 +00:00