From da7cd71be894aabb8d5b70e820e3c9ffec38ea70 Mon Sep 17 00:00:00 2001 From: Mark Baker Date: Mon, 17 Jun 2013 12:01:51 +0100 Subject: [PATCH] Minor performance tweaks --- Classes/PHPExcel/Worksheet.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Classes/PHPExcel/Worksheet.php b/Classes/PHPExcel/Worksheet.php index bd5dc17..4c7b239 100644 --- a/Classes/PHPExcel/Worksheet.php +++ b/Classes/PHPExcel/Worksheet.php @@ -1176,7 +1176,8 @@ class PHPExcel_Worksheet implements PHPExcel_IComparable $this->_cachedHighestColumn = $aCoordinates[0]; $this->_cachedHighestRow = max($this->_cachedHighestRow, $aCoordinates[1]); - // Cell needs appropriate xfIndex + // Cell needs appropriate xfIndex from dimensions records + // but don't create dimension records if they don't already exist $rowDimension = $this->getRowDimension($aCoordinates[1], FALSE); $columnDimension = $this->getColumnDimension($aCoordinates[0], FALSE); @@ -1192,7 +1193,7 @@ class PHPExcel_Worksheet implements PHPExcel_IComparable } /** - * Cell at a specific coordinate exists? + * Does the cell at a specific coordinate exist? * * @param string $pCoordinate Coordinate of the cell * @throws PHPExcel_Exception