RetailCRM-Mirror/PHPExcel
1
0
Fork 0
mirror of https://github.com/retailcrm/PHPExcel.git synced 2024-11-26 15:26:03 +03:00
Code Issues Projects Releases Wiki Activity

Minor performance tweak to OfficeOpenXML and BIFF Readers

Browse Source
This commit is contained in:
MarkBaker 2015-05-26 15:50:44 +01:00
parent 891478f6ab
commit 77cc77209b
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Classes/PHPExcel/Reader/Excel2007.php
View File

@ -951,8 +951,7 @@ class PHPExcel_Reader_Excel2007 extends PHPExcel_Reader_Abstract implements PHPE
} }
// Extract all cell references in $ref // Extract all cell references in $ref
$aReferences = PHPExcel_Cell::extractAllCellReferencesInRange($ref); foreach (PHPExcel_Cell::extractAllCellReferencesInRange($ref) as $reference) {
foreach ($aReferences as $reference) {
$docSheet->getStyle($reference)->setConditionalStyles($conditionalStyles); $docSheet->getStyle($reference)->setConditionalStyles($conditionalStyles);
} }
} }
@ -1178,8 +1177,7 @@ class PHPExcel_Reader_Excel2007 extends PHPExcel_Reader_Abstract implements PHPE
$stRange = $docSheet->shrinkRangeToFit($range); $stRange = $docSheet->shrinkRangeToFit($range);
// Extract all cell references in $range // Extract all cell references in $range
$aReferences = PHPExcel_Cell::extractAllCellReferencesInRange($stRange); foreach (PHPExcel_Cell::extractAllCellReferencesInRange($stRange) as $reference) {
foreach ($aReferences as $reference) {
// Create validation // Create validation
$docValidation = $docSheet->getCell($reference)->getDataValidation(); $docValidation = $docSheet->getCell($reference)->getDataValidation();
$docValidation->setType((string) $dataValidation["type"]); $docValidation->setType((string) $dataValidation["type"]);

3
Classes/PHPExcel/Reader/Excel5.php
View File

@ -4883,8 +4883,7 @@ class PHPExcel_Reader_Excel5 extends PHPExcel_Reader_Abstract implements PHPExce
foreach ($cellRangeAddresses as $cellRange) { foreach ($cellRangeAddresses as $cellRange) {
$stRange = $this->phpSheet->shrinkRangeToFit($cellRange); $stRange = $this->phpSheet->shrinkRangeToFit($cellRange);
$stRange = PHPExcel_Cell::extractAllCellReferencesInRange($stRange); foreach (PHPExcel_Cell::extractAllCellReferencesInRange($stRange) as $coordinate) {
foreach ($stRange as $coordinate) {
$objValidation = $this->phpSheet->getCell($coordinate)->getDataValidation(); $objValidation = $this->phpSheet->getCell($coordinate)->getDataValidation();
$objValidation->setType($type); $objValidation->setType($type);
$objValidation->setErrorStyle($errorStyle); $objValidation->setErrorStyle($errorStyle);