mirror of
https://github.com/retailcrm/NelmioApiDocBundle.git
synced 2025-02-02 15:51:48 +03:00
14d1021c8b
This is the result of https://github.com/nelmio/NelmioApiDocBundle/issues/410. This PR aims to provide a uniform way of declaring data-types of parameters for parsers and handlers to follow. In turn, this would allow formatters to determine data-types in a cleaner and less volatile manner. (See use-case that can be improved with this PR: https://github.com/nelmio/NelmioApiDocBundle/blob/master/Formatter/AbstractFormatter.php#L103) This is possible by the addition two properties to each property item in `response`, and `parameters` fields in each API endpoint produced by the `ApiDocExtractor`: * `actualType` Contains a value from one of the `DataTypes` class constants. * `subType` Can contain either `null`, or any other `DataTypes` class constant. This is relevant when the `actualType` is a `DataTypes::COLLECTION`, wherein `subType` would specify the type of the collection items. It is also relevant when `actualType` is a `DataTypes::MODEL`, wherein `subType` would contain an identifier of the model (the FQCN or anything the parser would wish to specify) Examples: ```php array( 'id' => array( 'dataType' => 'integer', 'actualType' => DataTypes::INTEGER, 'subType' => null, ), 'profile' => array( 'dataType' => 'object (Profile)', 'actualType' => DataTypes::MODEL, 'subType' => 'Foo\Entity\Profile', 'children' => array( 'name' => array( 'dataType' => 'string', 'actualType' => DataTypes::STRING, 'subType' => null, ), 'birthDate' => array( 'dataType' => 'date', 'actualType' => DataTypes::DATE, 'subType' => null, ), ) ), 'languages' => array( 'dataType' => 'array of strings', 'actualType' => DataTypes::COLLECTION, 'subType' => DataTypes::STRING, ), 'roles' => array( 'dataType' => 'array of choices', 'actualType' => DataTypes::COLLECTION, 'subType' => DataTypes::ENUM, ), 'groups' => array( 'dataType' => 'array of objects (Group)', 'actualType' => DataTypes::COLLECTION, 'subType' => 'Foo\Entity\Group', ), 'profileRevisions' => array( 'dataType' => 'array of objects (Profile)', 'actualType' => DataTypes::COLLECTION, 'subType' => 'Foo\Entity\Profile', ), 'address' => array( 'dataType' => 'object (a_type_a_custom_JMS_serializer_handler_handles)', 'actualType' => DataTypes::MODEL, 'subType' => 'a_type_a_custom_JMS_serializer_handler_handles', ), ); ``` When a formatter omits the `dataType` property or leaves it blank, it is inferred within `ApiDocExtractor` before everything is passed to formatters.
164 lines
5.1 KiB
PHP
164 lines
5.1 KiB
PHP
<?php
|
|
namespace NelmioApiDocBundle\Tests\Parser;
|
|
|
|
use Nelmio\ApiDocBundle\DataTypes;
|
|
use Nelmio\ApiDocBundle\Tests\WebTestCase;
|
|
use Nelmio\ApiDocBundle\Parser\ValidationParser;
|
|
use Nelmio\ApiDocBundle\Parser\ValidationParserLegacy;
|
|
use Symfony\Component\HttpKernel\Kernel;
|
|
|
|
class ValidationParserTest extends WebTestCase
|
|
{
|
|
protected $handler;
|
|
|
|
public function setUp()
|
|
{
|
|
$container = $this->getContainer();
|
|
$factory = $container->get('validator')->getMetadataFactory();
|
|
|
|
if (version_compare(Kernel::VERSION, '2.2.0', '<')) {
|
|
$this->parser = new ValidationParserLegacy($factory);
|
|
} else {
|
|
$this->parser = new ValidationParser($factory);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataTestParser
|
|
*/
|
|
public function testParser($property, $expected)
|
|
{
|
|
$result = $this->parser->parse(array('class' => 'Nelmio\ApiDocBundle\Tests\Fixtures\Model\ValidatorTest'));
|
|
foreach ($expected as $name => $value) {
|
|
$this->assertArrayHasKey($property, $result);
|
|
$this->assertArrayHasKey($name, $result[$property]);
|
|
$this->assertEquals($result[$property][$name], $expected[$name]);
|
|
}
|
|
}
|
|
|
|
public function dataTestParser()
|
|
{
|
|
return array(
|
|
array(
|
|
'property' => 'length10',
|
|
'expected' => array(
|
|
'format' => '{length: min: 10}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'length1to10',
|
|
'expected' => array(
|
|
'format' => '{length: min: 1, max: 10}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'notblank',
|
|
'expected' => array(
|
|
'required' => true
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'notnull',
|
|
'expected' => array(
|
|
'required' => true
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'type',
|
|
'expected' => array(
|
|
'dataType' => 'DateTime',
|
|
'actualType' => DataTypes::DATETIME,
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'date',
|
|
'expected' => array(
|
|
'format' => '{Date YYYY-MM-DD}',
|
|
'actualType' => DataTypes::DATE,
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'dateTime',
|
|
'expected' => array(
|
|
'format' => '{DateTime YYYY-MM-DD HH:MM:SS}',
|
|
'actualType' => DataTypes::DATETIME,
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'time',
|
|
'expected' => array(
|
|
'format' => '{Time HH:MM:SS}',
|
|
'actualType' => DataTypes::TIME,
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'email',
|
|
'expected' => array(
|
|
'format' => '{email address}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'url',
|
|
'expected' => array(
|
|
'format' => '{url}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'ip',
|
|
'expected' => array(
|
|
'format' => '{ip address}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'singlechoice',
|
|
'expected' => array(
|
|
'format' => '[a|b]',
|
|
'actualType' => DataTypes::ENUM,
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'multiplechoice',
|
|
'expected' => array(
|
|
'format' => '{choice of [x|y|z]}',
|
|
'actualType' => DataTypes::COLLECTION,
|
|
'subType' => DataTypes::ENUM,
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'multiplerangechoice',
|
|
'expected' => array(
|
|
'format' => '{min: 2 max: 3 choice of [foo|bar|baz|qux]}',
|
|
'actualType' => DataTypes::COLLECTION,
|
|
'subType' => DataTypes::ENUM,
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'regexmatch',
|
|
'expected' => array(
|
|
'format' => '{match: /^\d{1,4}\w{1,4}$/}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'regexnomatch',
|
|
'expected' => array(
|
|
'format' => '{not match: /\d/}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'multipleassertions',
|
|
'expected' => array(
|
|
'required' => true,
|
|
'dataType' => 'string',
|
|
'format' => '{email address}'
|
|
)
|
|
),
|
|
array(
|
|
'property' => 'multipleformats',
|
|
'expected' => array(
|
|
'format' => '{url}, {length: min: 10}'
|
|
)
|
|
)
|
|
);
|
|
}
|
|
}
|