diff --git a/ModelDescriber/ObjectModelDescriber.php b/ModelDescriber/ObjectModelDescriber.php index fc86439..893ae96 100644 --- a/ModelDescriber/ObjectModelDescriber.php +++ b/ModelDescriber/ObjectModelDescriber.php @@ -22,11 +22,13 @@ use Nelmio\ApiDocBundle\PropertyDescriber\PropertyDescriberInterface; use OpenApi\Annotations as OA; use Symfony\Component\PropertyInfo\PropertyInfoExtractorInterface; use Symfony\Component\PropertyInfo\Type; +use Symfony\Component\Serializer\Annotation\DiscriminatorMap; use Symfony\Component\Serializer\NameConverter\NameConverterInterface; class ObjectModelDescriber implements ModelDescriberInterface, ModelRegistryAwareInterface { use ModelRegistryAwareTrait; + use ApplyOpenApiDiscriminatorTrait; /** @var PropertyInfoExtractorInterface */ private $propertyInfo; @@ -71,6 +73,17 @@ class ObjectModelDescriber implements ModelDescriberInterface, ModelRegistryAwar $annotationsReader = new AnnotationsReader($this->doctrineReader, $this->modelRegistry, $this->mediaTypes); $annotationsReader->updateDefinition($reflClass, $schema); + $discriminatorMap = $this->doctrineReader->getClassAnnotation($reflClass, DiscriminatorMap::class); + if ($discriminatorMap && $schema->discriminator === OA\UNDEFINED) { + $this->applyOpenApiDiscriminator( + $model, + $schema, + $this->modelRegistry, + $discriminatorMap->getTypeProperty(), + $discriminatorMap->getMapping() + ); + } + $propertyInfoProperties = $this->propertyInfo->getProperties($class, $context); if (null === $propertyInfoProperties) { diff --git a/Tests/Functional/Controller/ApiController.php b/Tests/Functional/Controller/ApiController.php index 4988efd..554b1eb 100644 --- a/Tests/Functional/Controller/ApiController.php +++ b/Tests/Functional/Controller/ApiController.php @@ -18,6 +18,7 @@ use Nelmio\ApiDocBundle\Annotation\Security; use Nelmio\ApiDocBundle\Tests\Functional\Entity\Article; use Nelmio\ApiDocBundle\Tests\Functional\Entity\CompoundEntity; use Nelmio\ApiDocBundle\Tests\Functional\Entity\SymfonyConstraints; +use Nelmio\ApiDocBundle\Tests\Functional\Entity\SymfonyDiscriminator; use Nelmio\ApiDocBundle\Tests\Functional\Entity\User; use Nelmio\ApiDocBundle\Tests\Functional\Form\DummyType; use Nelmio\ApiDocBundle\Tests\Functional\Form\UserType; @@ -221,4 +222,13 @@ class ApiController public function compoundEntityAction() { } + + /** + * @Route("/discriminator-mapping", methods={"GET", "POST"}) + * + * @OA\Response(response=200, description="Worked well!", @Model(type=SymfonyDiscriminator::class)) + */ + public function discriminatorMappingAction() + { + } } diff --git a/Tests/Functional/Entity/SymfonyDiscriminator.php b/Tests/Functional/Entity/SymfonyDiscriminator.php new file mode 100644 index 0000000..cd4e562 --- /dev/null +++ b/Tests/Functional/Entity/SymfonyDiscriminator.php @@ -0,0 +1,28 @@ +assertNotHasProperty('protectedField', $model); $this->assertNotHasProperty('protected', $model); } + + public function testModelsWithDiscriminatorMapAreLoadedWithOpenApiPolymorphism() + { + $model = $this->getModel('SymfonyDiscriminator'); + + $this->assertInstanceOf(OA\Discriminator::class, $model->discriminator); + $this->assertSame('type', $model->discriminator->propertyName); + $this->assertCount(2, $model->discriminator->mapping); + $this->assertArrayHasKey('one', $model->discriminator->mapping); + $this->assertArrayHasKey('two', $model->discriminator->mapping); + $this->assertNotSame(OA\UNDEFINED, $model->oneOf); + $this->assertCount(2, $model->oneOf); + } + + public function testDiscriminatorMapLoadsChildrenModels() + { + // get model does its own assertions + $this->getModel('SymfonyDiscriminatorOne'); + $this->getModel('SymfonyDiscriminatorTwo'); + } }